Skip to content

Fix lsl_get_channel_bytes to return 0 for cft_string as documented (extends #261) #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboulay merged 2 commits into from
Jun 17, 2026
Merged

Fix lsl_get_channel_bytes to return 0 for cft_string as documented (extends #261) #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2a4574
Fix lsl_get_channel_bytes to return 0 for cft_string as documented
myd7349 Jan 28, 2026
2a8e427
test: update tcpserver string endian case for zero-size string channels
cboulay Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/stream_info_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ bool query_cache::matches_query(const xml_document &doc, const std::string &quer
}

int stream_info_impl::channel_bytes() const {
const int channel_format_sizes[] = {0, sizeof(float), sizeof(double), sizeof(std::string),
const int channel_format_sizes[] = {0, sizeof(float), sizeof(double), 0,
sizeof(int32_t), sizeof(int16_t), sizeof(int8_t), 8};
return channel_format_sizes[channel_format_];
}
Expand Down
8 changes: 7 additions & 1 deletion testing/int/tcpserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "send_buffer.h"
#include "stream_info_impl.h"
#include "tcp_server.h"
#include "util/endian.hpp"
#include <asio/read.hpp>
#include <asio/read_until.hpp>
#include <asio/write.hpp>
Expand Down Expand Up @@ -138,10 +139,15 @@ TEST_CASE("tcpserver", "[network]") {
cmp_binstr(expected, received_pattern);
}));

// String channels report a per-channel value size of 0 (channel_bytes() == 0), so the server
// performs no endian conversion and advertises its own (host) byte order regardless of the
// client's request. Any needed swapping of the string length-prefixes happens on the receiving
// side instead (see tcpserver_float for the actual binary endian-conversion test).
send_request(ctx, ep, asio::buffer("LSL:streamfeed/199 \nNative-byte-order:4321\r\n\r\n"),
with_read_callback("endian", [](const std::string &res) {
REQUIRE(res.substr(0, 14) == "LSL/110 200 OK");
REQUIRE(res.find("Byte-Order: 4321") != std::string::npos);
REQUIRE(res.find("Byte-Order: " + std::to_string(static_cast<int>(lsl::LSL_BYTE_ORDER))) !=
std::string::npos);
}));

send_request(ctx, ep, asio::buffer("LSL:streamfeed\n0 0\r\n"),
Expand Down
Loading