Allow UID to be reset via C API (extends #260)#280
Merged
Conversation
Collapse the C wrapper to the one-line style of its siblings and expose a matching stream_info::reset_uid() in the C++ header for API parity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
@cboulay Wasn't sure where to mention this to you, but if you're interested, my liblsl.dart related paper finally got published in JOSS https://joss.theoj.org/papers/10.21105/joss.10425 :) |
cboulay
added a commit
to labstreaminglayer/pylsl
that referenced
this pull request
Jun 20, 2026
Wraps the new lsl_reset_uid C function (sccn/liblsl#280), which regenerates a stream_info's UID. Useful for assigning a UID to a locally-constructed StreamInfo before it is bound to an outlet/inlet. Raises NotImplementedError on older liblsl that lacks the symbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #260 by @zeyus, which exposes the existing
stream_info_impl::reset_uid()through the C API. Useful for generating a UID on a locally-constructedstream_infothat has not yet been associated with an inlet.This PR keeps @zeyus's original commit and adds a small follow-up commit:
lsl_reset_uidC wrapper to the one-line style of its siblings and drop a stray blank line.stream_info::reset_uid()wrapper toinclude/lsl_cpp.hfor C++/C API parity.Verified locally on macOS: configures and builds, and
_lsl_reset_uidis present in the exported symbols of the shared library.Closes #260.
🤖 Generated with Claude Code