Repository navigation
fix: preserve safe URL handling with markdown-it 15 attribute types - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dependabot #75 upgrades markdown-it to 15.0.3, but its
attrGet()return type now includesnumber; the current Scarp renderer expectsstring, so #75 fails TypeScript atscripts/scarp-site/markdown.tslines 123 and 136.Change
Narrow
hrefandsrctoken attributes to non-empty strings before passing to the documented URL sanitizer. This is compatible with the currently pinned markdown-it 14 runtime, preserves safe link handling, and prepares the renderer for markdown-it 15 without weakening the URL policy.Gate
CI must pass on current pinned markdown-it 14 before merging. Then re-check #75 separately under markdown-it 15; do not merge that major update without a green browser/docs suite.