Substract cache from memory usage.#2
Open
maleadt wants to merge 1 commit intoscanterog:masterfrom
maleadt:master
Open
Substract cache from memory usage.#2maleadt wants to merge 1 commit intoscanterog:masterfrom maleadt:master
maleadt wants to merge 1 commit intoscanterog:masterfrom
maleadt:master
Conversation
Owner
|
Hi @maleadt! Thanks for reporting this. I took a look and I've found that rss stat inside memory.stat always matches usage_in_bytes - cache. In case this is correct, we might open just one file and get rss out of it rather than opening two files and executing the subtraction operation. We might look into runc project in order to understand how rss (resident set size) is defined. According to this https://docs.docker.com/engine/admin/runmetrics/#memory-metrics-memorystat, rss should work, but I think it would be better total_rss because it includes sub-cgroups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including it seemed a bit misleading to me, as it doesn't reflect actual memory usage and wouldn't trigger eg. OOM. It also makes it hard to compare different container's behavior, where one might be leaking memory and the other just caching a lot.
Ref moby/moby#10824