Skip to content

fix typing of add_chart method #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LevonW-IIS wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix typing of add_chart method #1057

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56338fa
fix typing of add_chart
LevonW-IIS Apr 22, 2025
8b4ed17
fix formatting
LevonW-IIS Apr 22, 2025
8227925
fix formatting
LevonW-IIS Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/pptx/shapes/shapetree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
from pptx.util import Emu, lazyproperty

if TYPE_CHECKING:
from pptx.chart.chart import Chart
from pptx.chart.data import ChartData
from pptx.enum.chart import XL_CHART_TYPE
from pptx.enum.shapes import MSO_CONNECTOR_TYPE, MSO_SHAPE
Expand Down Expand Up @@ -241,7 +240,7 @@ def add_chart(
cx: Length,
cy: Length,
chart_data: ChartData,
) -> Chart:
) -> GraphicFrame:
"""Add a new chart of `chart_type` to the slide.

The chart is positioned at (`x`, `y`), has size (`cx`, `cy`), and depicts `chart_data`.
Expand All @@ -255,7 +254,7 @@ def add_chart(
rId = self.part.add_chart_part(chart_type, chart_data)
graphicFrame = self._add_chart_graphicFrame(rId, x, y, cx, cy)
self._recalculate_extents()
return cast("Chart", self._shape_factory(graphicFrame))
return cast(GraphicFrame, self._shape_factory(graphicFrame))

def add_connector(
self,
Expand Down