Implementation of Ordered Insertion Maps for encoding/decoding#6
Open
daidoji wants to merge 5 commits intoscalpel-software:masterfrom
Open
Implementation of Ordered Insertion Maps for encoding/decoding#6daidoji wants to merge 5 commits intoscalpel-software:masterfrom
daidoji wants to merge 5 commits intoscalpel-software:masterfrom
Conversation
Collaborator
|
@daidoji Thanks for the PR. I don't think this is quite the correct direction that I want to take since there have been changes to the cbor spec. My instinct is to add an optional decoder map where keys correspond to known tags within the database of tags. This way people could write their own implementations and share them as extensions to the spec. Let me think about this some more before outright rejecting. I will likely have some time this weekend to gather my thoughts and work on a plan. |
Author
|
@tomciopp thanks for the feedback and sure. Like I said just putting it out there. If I can help in any way please feel free to let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tomciopp A long time ago I opened #5 when I was pretty new to Elixir and didn't know much or have much time to work on this. At the time you didn't want to implement ordered maps in the library but suggested I could send a PR. Just got around to implementing it here if you'd like to accept the contribution as something that some people might find useful. If not feel free to close.