chore: Remove validation from reconcile loop#7
Merged
TeddyAndrieux merged 2 commits intomainfrom Nov 12, 2025
Merged
Conversation
ezekiel-alexrod
approved these changes
Nov 12, 2025
| if ces.Image == nil { | ||
| ces.Image = &ImageSpec{} | ||
| } | ||
| ces.Image.withDefaults() |
There was a problem hiding this comment.
Normally no default needed as the field is required.
Contributor
Author
There was a problem hiding this comment.
This is no longer mandatory
(I'm not really agree with this statement, it's not because a field is mandatory that you do not have "sub fields" with defaults that should be set)
There was a problem hiding this comment.
"mouais", in that case, you validate instead of defaulting
But no way, the field is no more mandatory
| // validationManagedCRL validates the ManagedCRL fields. | ||
| func validationManagedCRL(logger logr.Logger, ctx context.Context, c client.Client, managedcrl *crloperatorv1alpha1.ManagedCRL) error { | ||
| managedcrl.WithDefaults() | ||
| if err := managedcrl.Validate(); err != nil { |
There was a problem hiding this comment.
Why ? validation does not expected some default fields
Contributor
Author
There was a problem hiding this comment.
The withDefaults as been moved to the Validate function directly
TeddyAndrieux
force-pushed
the
improvement/remove-validate-from-reconcile
branch
2 times, most recently
from
b4096b2 to
713a0a8
Compare
Signed-off-by: Teddy Andrieux <teddy.andrieux@scality.com>
Signed-off-by: Teddy Andrieux <teddy.andrieux@scality.com>
TeddyAndrieux
force-pushed
the
improvement/remove-validate-from-reconcile
branch
from
713a0a8 to
6775a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.