Merged
Conversation
```shell operator-sdk create webhook --group crl-operator --version v1alpha1 --kind ManagedCRL --programmatic-validation ``` Signed-off-by: Teddy Andrieux <teddy.andrieux@scality.com>
Signed-off-by: Teddy Andrieux <teddy.andrieux@scality.com>
TeddyAndrieux
force-pushed
the
improvement/add-validation-webhook
branch
from
9f90cd0 to
195d371
Compare
anthony-treuillier-scality
approved these changes
Nov 12, 2025
anthony-treuillier-scality
left a comment
anthony-treuillier-scality
left a comment
There was a problem hiding this comment.
just one comment, but it is ok for me
Comment on lines
+93
to
+99
| managedcrl, ok := obj.(*crloperatorv1alpha1.ManagedCRL) | ||
| if !ok { | ||
| return nil, fmt.Errorf("expected a ManagedCRL object but got %T", obj) | ||
| } | ||
| managedcrllog.Info("Validation for ManagedCRL upon deletion", "name", managedcrl.GetName()) | ||
|
|
||
| // TODO(user): fill in your validation logic upon object deletion. |
There was a problem hiding this comment.
Any interest of keeping all this ?
Contributor
Author
There was a problem hiding this comment.
I kept it just to "remind" that today ValidateDelete is not implemented, but I could have updated it as well
ezekiel-alexrod
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.