chore: Add finalizer to handle CRL Distribution Point cleanup#3
Merged
TeddyAndrieux merged 1 commit intomainfrom Nov 7, 2025
Merged
Conversation
vdaviot
reviewed
Nov 4, 2025
vdaviot
reviewed
Nov 4, 2025
| // handleDeletion handles the deletion of a ManagedCRL resource by cleaning up | ||
| // the CRL distribution points from the issuer and removing the finalizer. | ||
| // nolint:unparam // ctrl.Result is always empty for deletion, which is expected | ||
| func (r *ManagedCRLReconciler) handleDeletion(logger logr.Logger, ctx context.Context, instance *crloperatorv1alpha1.ManagedCRL) (ctrl.Result, error) { |
There was a problem hiding this comment.
Wouldn't it be better to have the logger directly in the struct instead of passed as parameter ?
Contributor
Author
There was a problem hiding this comment.
Since we fill the logger with some context everytime we reconcile I'm not sure it's a good idea here
But for lager operator I would have a "intermediate struct" that would include the logger yes
TeddyAndrieux
force-pushed
the
improvement/add-finalizer-to-clean-crl-dp
branch
2 times, most recently
from
f18cb69 to
80f25a3
Compare
TeddyAndrieux
force-pushed
the
improvement/update-ci
branch
from
9282f4d to
5bd951a
Compare
TeddyAndrieux
force-pushed
the
improvement/add-finalizer-to-clean-crl-dp
branch
from
80f25a3 to
252a5e4
Compare
TeddyAndrieux
force-pushed
the
improvement/update-ci
branch
from
5bd951a to
c8c50c7
Compare
TeddyAndrieux
force-pushed
the
improvement/add-finalizer-to-clean-crl-dp
branch
from
252a5e4 to
6b36429
Compare
Signed-off-by: Teddy Andrieux <teddy.andrieux@scality.com>
TeddyAndrieux
force-pushed
the
improvement/add-finalizer-to-clean-crl-dp
branch
from
6b36429 to
3ef2c5f
Compare
anthony-treuillier-scality
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.