Skip to content

👷(CLDSRV-858) Improve bucket naming gcp #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bert-e merged 2 commits into from
Feb 24, 2026
+21 −21
Merged

👷(CLDSRV-858) Improve bucket naming gcp #6086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e250e1
✨ update bucket naming for GCP test to be able to identify them in th…
DarkIsDude Feb 24, 2026
79289de
♻️ reduce bucket name length to be compliant with GCP
DarkIsDude Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/bucket/get.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const { getRealAwsConfig } =
const { listingHardLimit } = require('../../../../../../constants');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-get-${genUniqID()}`;
const smallSize = 20;
const bigSize = listingHardLimit + 1;
const config = getRealAwsConfig(credentialOne);
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/bucket/getVersioning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('GCP: GET Bucket Versioning', () => {
const gcpClient = new GCP(config);

beforeEach(async function beforeFn() {
this.currentTest.bucketName = `somebucket-${genUniqID()}`;
this.currentTest.bucketName = `cldsrvci-getversioning-${genUniqID()}`;
await gcpRetry(
gcpClient,
new CreateBucketCommand({
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/raw-node/test/GCP/bucket/head.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('GCP: HEAD Bucket', () => {

describe('without existing bucket', () => {
beforeEach(async function beforeFn() {
this.currentTest.bucketName = `somebucket-${genUniqID()}`;
this.currentTest.bucketName = `cldsrvci-head-${genUniqID()}`;
});

it('should return 404', async function testFn() {
Expand All @@ -37,7 +37,7 @@ describe('GCP: HEAD Bucket', () => {

describe('with existing bucket', () => {
beforeEach(async function beforeFn() {
this.currentTest.bucketName = `somebucket-${genUniqID()}`;
this.currentTest.bucketName = `cldsrvci-head-${genUniqID()}`;
process.stdout
.write(`Creating test bucket ${this.currentTest.bucketName}\n`);
await gcpRetry(
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/bucket/putVersioning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const { getRealAwsConfig } =
const credentialOne = 'gcpbackend';
const verEnabledStatus = 'Enabled';
const verDisabledStatus = 'Suspended';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-putversioning-${genUniqID()}`;

describe('GCP: PUT Bucket Versioning', () => {
const config = getRealAwsConfig(credentialOne);
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/raw-node/test/GCP/object/completeMpu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ const {
const credentialOne = 'gcpbackend';
const bucketNames = {
main: {
Name: `somebucket-${genUniqID()}`,
Name: `cldsrvci-completempu-${genUniqID()}`,
Type: 'MULTI_REGIONAL',
},
mpu: {
Name: `mpubucket-${genUniqID()}`,
Name: `cldsrvci-mpu-completempu-${genUniqID()}`,
Type: 'MULTI_REGIONAL',
},
};
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-copy-${genUniqID()}`;

describe('GCP: COPY Object', function testSuite() {
this.timeout(180000);
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/delete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-deleteobj-${genUniqID()}`;
const objectKey = `somekey-${genUniqID()}`;
const badObjectKey = `nonexistingkey-${genUniqID()}`;

Expand Down
4 changes: 2 additions & 2 deletions tests/functional/raw-node/test/GCP/object/deleteMpu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ const {
const credentialOne = 'gcpbackend';
const bucketNames = {
main: {
Name: `somebucket-${genUniqID()}`,
Name: `cldsrvci-deletempu-${genUniqID()}`,
},
mpu: {
Name: `mpubucket-${genUniqID()}`,
Name: `cldsrvci-mpu-deletempu-${genUniqID()}`,
},
};
const numParts = 10;
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/deleteTagging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-deletetagging-${genUniqID()}`;
let config;
let gcpClient;

Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/get.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-get-${genUniqID()}`;

describe('GCP: GET Object', function testSuite() {
this.timeout(30000);
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/getTagging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-gettagging-${genUniqID()}`;
const tagSize = 10;

describe('GCP: GET Object Tagging', () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/head.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-head-${genUniqID()}`;

describe('GCP: HEAD Object', function testSuite() {
this.timeout(30000);
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/raw-node/test/GCP/object/initiateMpu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ const {
const credentialOne = 'gcpbackend';
const bucketNames = {
main: {
Name: `somebucket-${genUniqID()}`,
Name: `cldsrvci-initiatempu-${genUniqID()}`,
},
mpu: {
Name: `mpubucket-${genUniqID()}`,
Name: `cldsrvci-mpu-initiatempu-${genUniqID()}`,
},
};

Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/put.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-put-${genUniqID()}`;

describe('GCP: PUT Object', function testSuite() {
this.timeout(30000);
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/raw-node/test/GCP/object/putTagging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const {
} = require('@aws-sdk/client-s3');

const credentialOne = 'gcpbackend';
const bucketName = `somebucket-${genUniqID()}`;
const bucketName = `cldsrvci-puttagging-${genUniqID()}`;

describe('GCP: PUT Object Tagging', () => {
let config;
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/raw-node/test/GCP/object/upload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ const {
const credentialOne = 'gcpbackend';
const bucketNames = {
main: {
Name: `somebucket-${genUniqID()}`,
Name: `cldsrvci-upload-${genUniqID()}`,
},
mpu: {
Name: `mpubucket-${genUniqID()}`,
Name: `cldsrvci-mpu-upload-${genUniqID()}`,
},
};

Expand Down
Loading