Skip to content

🐛(ZENKO-5288) wrap kafka-server-start.sh to propagate broker exit code #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkIsDude wants to merge 2 commits into
base: development/2.15
Choose a base branch
from
+9 −0
Open

🐛(ZENKO-5288) wrap kafka-server-start.sh to propagate broker exit code #2428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a9dfdf
🐛 wrap kafka-server-start.sh to propagate broker exit code
DarkIsDude Jun 3, 2026
7783b78
🐛 wrap kafka-server-start.sh to propagate broker exit code
DarkIsDude Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions solution/kafka/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,8 @@ COPY log4j.properties ${KAFKA_HOME}/config/

RUN chmod a+x ${KAFKA_HOME}/bin/*.sh

RUN mv ${KAFKA_HOME}/bin/kafka-server-start.sh ${KAFKA_HOME}/bin/kafka-server-start-real.sh

@francoisferrand francoisferrand Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: not fond of "real", maybe "origin", "upstream" or "wrapped" ? (Not sure which is really better, if any...)

Suggested change
RUN mv ${KAFKA_HOME}/bin/kafka-server-start.sh ${KAFKA_HOME}/bin/kafka-server-start-real.sh
RUN mv ${KAFKA_HOME}/bin/kafka-server-start.sh ${KAFKA_HOME}/bin/kafka-server-start-origin.sh


COPY --chmod=755 kafka-server-start.sh ${KAFKA_HOME}/bin/kafka-server-start.sh

@francoisferrand francoisferrand Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chmod should not be needed: commit the ˋchmod`´ed file and it will be fine


CMD ["kafka-server-start.sh"]
5 changes: 5 additions & 0 deletions solution/kafka/kafka-server-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/bin/bash
"$(dirname "$0")/kafka-server-start-real.sh" "$@"
KAFKA_EXIT=$?
printf "%d" "$KAFKA_EXIT" > /var/run/kafka-exit/code
exit "$KAFKA_EXIT"
Loading