Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experiments/agentcompany/openhands/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ smmap==5.0.1
sniffio==1.3.1
soupsieve==2.5
stack-data==0.6.3
starlette==0.41.2
starlette==1.0.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Starlette version conflicts with pinned FastAPI

fastapi==0.115.4 (line 43) declares a starlette requirement of >=0.40.0,<0.42.0 — FastAPI 0.115.3 explicitly upgraded to that range and 0.115.4 carries the same constraint. Pinning starlette==1.0.1 here directly violates that upper bound, so pip install will error on conflicting requirements. To adopt starlette 1.0.x, fastapi must first be upgraded to a version that declares compatibility with starlette ≥1.0 (FastAPI 0.136.x+ began bumping starlette to 1.0.0).

Prompt To Fix With AI
This is a comment left during a code review.
Path: experiments/agentcompany/openhands/requirements.txt
Line: 169

Comment:
**Starlette version conflicts with pinned FastAPI**

`fastapi==0.115.4` (line 43) declares a starlette requirement of `>=0.40.0,<0.42.0` — FastAPI 0.115.3 explicitly upgraded to that range and 0.115.4 carries the same constraint. Pinning `starlette==1.0.1` here directly violates that upper bound, so `pip install` will error on conflicting requirements. To adopt starlette 1.0.x, `fastapi` must first be upgraded to a version that declares compatibility with starlette ≥1.0 (FastAPI 0.136.x+ began bumping starlette to 1.0.0).

How can I resolve this? If you propose a fix, please make it concise.

Fix in Cursor Fix in Claude Code Fix in Codex

sympy==1.13.1
terminado==0.18.1
threadpoolctl==3.5.0
Expand Down