Skip to content

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Nov 18, 2020

  • readme tweaks
  • bump MiMa reference version

(CI won't pass until 1.0.0 hits Maven Central)

* readme tweaks
* bump MiMa reference version
@SethTisue SethTisue self-assigned this Nov 18, 2020
@SethTisue SethTisue mentioned this pull request Nov 18, 2020
@SethTisue
Copy link
Member Author

(CI won't pass until 1.0.0 hits Maven Central)

ha, wrong:

[warn] MiMa will NOT run because the previous artifact "org.scala-lang.modules" % "scala-parallel-collections_2.13" % "1.0.0" could not be resolved (note the binary Scala version).m
[warn] MiMa will NOT run because no mimaPreviousVersion is provided.
[warn] MiMa will NOT run because no mimaPreviousVersion is provided.

but it doesn't fail the build. even though mimaFailOnNoPrevious is true!

@dwijnand am I missing something here about how this is intended to work?

@SethTisue SethTisue merged commit d7d3aad into scala:master Nov 18, 2020
@SethTisue SethTisue deleted the post-1.0.0-release branch November 18, 2020 04:34
@dwijnand
Copy link
Member

I know how sbt-mima-plugin works, but I don't know what https://github.com/scala/sbt-scala-module/blob/ddbdcacb2b2af10373307c5f5ea1257e23a1f7bf/src/main/scala/ScalaModulePlugin.scala#L181 is doing (and frankly don't care as I would rather it didn't exist... 😠 )

@lrytz
Copy link
Member

lrytz commented Nov 19, 2020

This goal for this was to avoid spurious failures when releasing against a new binary version. Say we have parallel-collections %% 1.0.0 as the mima reference version. In the meantime we are at 1.0.3. Now a new Scala binary version comes along, e.g., 3.0.0-M1. When building parallel-collections_3.0.0-M1 % 1.0.3, the mima reference parallel-collections_3.0.0-M1 % 1.0.0 doesn't exist.

We've now decided to remove support for back-releasing against new binary versions (scala/scala-xml#417, I still want to push that through all other module repos), then we can also remove this mima-sbt hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants