Moved Scissor Lift Checkout Validation logic to the model#358
Merged
merichar merged 4 commits intosc0v:masterfrom Feb 20, 2026
Merged
Moved Scissor Lift Checkout Validation logic to the model#358merichar merged 4 commits intosc0v:masterfrom
merichar merged 4 commits intosc0v:masterfrom
Conversation
tomas-goncalves
changed the title
tomas-goncalves
changed the title
merichar
reviewed
Feb 20, 2026
merichar
reviewed
Feb 20, 2026
merichar
reviewed
Feb 20, 2026
merichar
requested changes
Feb 20, 2026
Member
merichar
left a comment
merichar
left a comment
There was a problem hiding this comment.
Good work moving validations into the model. A few changes needed before this is ready:
- checkin and renew_for should use save! instead of save
- Please remove checkout_batch
merichar
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.