Conversation
|
@eed3si9n the PR for the 1.x branch only has two errors. In the |
|
@nightscape It seems like even the 1.x version doesn't work on windows? Might be we need to fix more than what you mentioned in #472 |
|
@fnqista yes, the two errors I mentioned above are unrelated to the |
|
@nightscape I have had a chance to look at this (tbh I almost didn't want to because I dislike Windows development, but I am responsible for the 2.0 changes so I feel obligated to help):
Edit: There is another failure in 2.x, where we use I can prepare a new PR with all the fixes for the above. Can you get Eugene to merge your PR first? |
|
@fnqista the other PR is merged 👍 |
No description provided.