Skip to content

Use ClassTag instead Manifest#492

Open
xuwei-k wants to merge 1 commit intosbt:developfrom
xuwei-k:ClassTag-Manifest-targetName
Open

Use ClassTag instead Manifest#492
xuwei-k wants to merge 1 commit intosbt:developfrom
xuwei-k:ClassTag-Manifest-targetName

Conversation

@xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Mar 1, 2026

@xuwei-k xuwei-k force-pushed the ClassTag-Manifest-targetName branch from d78f231 to 8b67298 Compare March 1, 2026 11:22
@xuwei-k
Copy link
Member Author

xuwei-k commented Mar 1, 2026

[error] org.scalafmt.sbt.ScalafmtSbtReporter$ScalafmtSbtError: scalafmt: [3.10.7] /home/runner/work/io/io/io/src/main/scala/sbt/io/IO.scala:94: error: [dialect scala212source3 [with overrides]] `identifier` expected but `:` found
[error]   def classLocationPath[A](using tag: ClassTag[A]): NioPath =
[error]                                     ^ [/home/runner/work/io/io/io/src/main/scala/sbt/io/IO.scala]
[error] (io / Compile / scalafmtCheck) org.scalafmt.sbt.ScalafmtSbtReporter$ScalafmtSbtError: scalafmt: [3.10.7] /home/runner/work/io/io/io/src/main/scala/sbt/io/IO.scala:94: error: [dialect scala212source3 [with overrides]] `identifier` expected but `:` found
[error]   def classLocationPath[A](using tag: ClassTag[A]): NioPath =
[error]                                     ^ [/home/runner/work/io/io/io/src/main/scala/sbt/io/IO.scala]
[error] Total time: 6 s, completed Mar 1, 2026, 11:23:40 AM

@eed3si9n
Copy link
Member

eed3si9n commented Mar 1, 2026

As long as Manifest keeps functioning in Scala 3, I don't think we need to replace it?

@xuwei-k xuwei-k force-pushed the ClassTag-Manifest-targetName branch from 8b67298 to e377279 Compare March 1, 2026 22:21
@xuwei-k xuwei-k marked this pull request as ready for review March 1, 2026 22:22
@xuwei-k xuwei-k force-pushed the ClassTag-Manifest-targetName branch from e377279 to 9df98b4 Compare March 2, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants