Add missing deptrack upload options#230
Conversation
|
Thanks @Erik-Hoffmann. Issues to address before merge: Blockers
Correctness
Style
Minor
|
|
Hi @vpetersson thank you for your review! I addressed all issues you mentioned. Sorry for not adding tests, that was my stupidity, also I am not working a lot with Github so sorry for not using Branching best-practices here^^ I hope that you (and Claude) are happy with the changes now, else please share again such a detailed review, that is much appreciated. |
|
Thanks @Erik-Hoffmann — the substantive feedback is all addressed. Tests pass locally (73/73), ruff lint + format both clean. A few items still outstanding: Still outstanding
Nit (non-blocking)
Once those are cleaned up I think this is good to go. |
|
Correction to my previous comment — Sanity Checks is actually failing on CI. I only ran Reproduced locally with
Apologies for the misleading "lint + format clean" line — it was true but incomplete. |
|
@vpetersson thank you for the quick review. Since you suggested to split the README formatting in a separate commit, I did that - but ok, I dropped the formatting now. I changed the |
Summary
DTRACK_PROJECT_TAGS- Tags to add to the project (comma seperated)DTRACK_PARENT_ID- Id of the parent projectDTRACK_PARENT_NAME- Name of the parent projectDTRACK_PARENT_VERSION- Version of the parent projectDTRACK_IS_LATEST- Mark the uploaded BOM as the latest version (default: false)procol.py:_get_env_list, which returns a comma seperated env option as a list.closes: #212