Skip to content

Only call loadPlugins once in constructors. #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luciansmith wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Only call loadPlugins once in constructors. #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4990ae0
Only call loadPlugins once in constructors.
luciansmith Apr 29, 2025
341dce5
KeyValuePair is not actually a subclass of Transformation.
luciansmith Feb 11, 2026
7d32721
Fix comments.
luciansmith Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sbml/packages/distrib/sbml/DistribBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ DistribBase::DistribBase(DistribPkgNamespaces *distribns)
, mElementName("distribBase")
{
setElementNamespace(distribns->getURI());
connectToChild();
loadPlugins(distribns);
}

Expand Down
7 changes: 5 additions & 2 deletions src/sbml/packages/distrib/sbml/UncertParameter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,12 @@ UncertParameter::UncertParameter(DistribPkgNamespaces *distribns)
, mUncertParameters (new ListOfUncertParameters (distribns))
, mMath (NULL)
{
setElementNamespace(distribns->getURI());
connectToChild();
loadPlugins(distribns);
//
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (DistribBase).
//
}


Expand Down
8 changes: 6 additions & 2 deletions src/sbml/packages/distrib/sbml/UncertSpan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,12 @@ UncertSpan::UncertSpan(DistribPkgNamespaces *distribns)
, mValueUpper (util_NaN())
, mIsSetValueUpper (false)
{
setElementNamespace(distribns->getURI());
loadPlugins(distribns);
connectToChild();
//
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (UncertParameter).
//
}


Expand Down
7 changes: 5 additions & 2 deletions src/sbml/packages/distrib/sbml/Uncertainty.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,12 @@ Uncertainty::Uncertainty(DistribPkgNamespaces *distribns)
: DistribBase(distribns)
, mUncertParameters (distribns)
{
setElementNamespace(distribns->getURI());
connectToChild();
loadPlugins(distribns);
//
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (DistribBase).
//
}


Expand Down
12 changes: 5 additions & 7 deletions src/sbml/packages/fbc/sbml/FbcAnd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,12 @@ FbcAnd::FbcAnd (FbcPkgNamespaces* fbcns)
: FbcAssociation(fbcns)
, mAssociations (fbcns)
{
// set the element namespace of this object
setElementNamespace(fbcns->getURI());

// connect to child objects
connectToChild();

// load package extensions bound with this object (if any)
loadPlugins(fbcns);
//
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (FbcAssociation).
//
}


Expand Down
12 changes: 5 additions & 7 deletions src/sbml/packages/fbc/sbml/FbcOr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,12 @@ FbcOr::FbcOr (FbcPkgNamespaces* fbcns)
: FbcAssociation(fbcns)
, mAssociations (fbcns)
{
// set the element namespace of this object
setElementNamespace(fbcns->getURI());

// connect to child objects
connectToChild();

// load package extensions bound with this object (if any)
loadPlugins(fbcns);
//
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (FbcAssociation).
//
}


Expand Down
11 changes: 6 additions & 5 deletions src/sbml/packages/fbc/sbml/GeneProductRef.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,12 @@ GeneProductRef::GeneProductRef (FbcPkgNamespaces* fbcns)
, mGeneProduct ("")
// , mName ("")
{
// set the element namespace of this object
setElementNamespace(fbcns->getURI());

// load package extensions bound with this object (if any)
loadPlugins(fbcns);
connectToChild();
//
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (FbcAssociation).
//
}


Expand Down
1 change: 1 addition & 0 deletions src/sbml/packages/fbc/sbml/KeyValuePair.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ KeyValuePair::KeyValuePair(FbcPkgNamespaces *fbcns)
, mUri ("")
{
setElementNamespace(fbcns->getURI());
connectToChild();
loadPlugins(fbcns);
}

Expand Down
39 changes: 11 additions & 28 deletions src/sbml/packages/layout/sbml/CompartmentGlyph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ CompartmentGlyph::CompartmentGlyph (unsigned int level, unsigned int version, un
, mOrder(numeric_limits<double>::quiet_NaN())
, mIsSetOrder(false)
{
connectToChild();
//
// (NOTE) Developers don't have to invoke setSBMLNamespacesAndOwn function as follows (commentted line)
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the function is properly invoked in the constructor of the
// base class (GraphicalObject).
//
Expand All @@ -91,18 +92,12 @@ CompartmentGlyph::CompartmentGlyph(LayoutPkgNamespaces* layoutns)
, mOrder(numeric_limits<double>::quiet_NaN())
, mIsSetOrder(false)
{
connectToChild();
//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//

// setElementNamespace(layoutns->getURI());

//
// load package extensions bound with this object (if any)
//
loadPlugins(layoutns);
}


Expand All @@ -116,18 +111,12 @@ CompartmentGlyph::CompartmentGlyph (LayoutPkgNamespaces* layoutns, const std::st
, mIsSetOrder(false)

{
connectToChild();
//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//

// setElementNamespace(layoutns->getURI());

//
// load package extensions bound with this object (if any)
//
loadPlugins(layoutns);
}

/*
Expand All @@ -141,18 +130,12 @@ CompartmentGlyph::CompartmentGlyph (LayoutPkgNamespaces* layoutns, const std::st
, mIsSetOrder(false)

{
connectToChild();
//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//

// setElementNamespace(layoutns->getURI());

//
// load package extensions bound with this object (if any)
//
loadPlugins(layoutns);
}

/*
Expand Down
76 changes: 18 additions & 58 deletions src/sbml/packages/layout/sbml/CubicBezier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,19 +101,11 @@ CubicBezier::CubicBezier(LayoutPkgNamespaces* layoutns)
this->mBasePoint2.setElementName("basePoint2");

connectToChild();

//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
//

// setElementNamespace(layoutns->getURI());

//
// load package extensions bound with this object (if any)
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//
loadPlugins(layoutns);
}


Expand All @@ -133,19 +125,11 @@ CubicBezier::CubicBezier (LayoutPkgNamespaces* layoutns, double x1, double y1, d
this->mBasePoint2.setElementName("basePoint2");

connectToChild();

//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//

// setElementNamespace(layoutns->getURI());

//
// load package extensions bound with this object (if any)
//
loadPlugins(layoutns);
}


Expand All @@ -166,19 +150,11 @@ CubicBezier::CubicBezier (LayoutPkgNamespaces* layoutns, double x1, double y1, d
this->mBasePoint2.setElementName("basePoint2");

connectToChild();

//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
//

// setElementNamespace(layoutns->getURI());

//
// load package extensions bound with this object (if any)
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//
loadPlugins(layoutns);
}

/*
Expand Down Expand Up @@ -245,19 +221,11 @@ CubicBezier::CubicBezier (LayoutPkgNamespaces* layoutns, const Point* start, con
this->mBasePoint2.setElementName("basePoint2");

connectToChild();

//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
//

// setElementNamespace(layoutns->getURI());

// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//
// load package extensions bound with this object (if any)
//
loadPlugins(layoutns);
}


Expand Down Expand Up @@ -285,20 +253,12 @@ CubicBezier::CubicBezier (LayoutPkgNamespaces* layoutns, const Point* start, con
this->mEndPoint=Point(layoutns);
}

connectToChild();

//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
//

// setElementNamespace(layoutns->getURI());

//
// load package extensions bound with this object (if any)
//
loadPlugins(layoutns);
connectToChild();
//
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//
}

/*
Expand Down
43 changes: 9 additions & 34 deletions src/sbml/packages/layout/sbml/GeneralGlyph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,21 +119,12 @@ GeneralGlyph::GeneralGlyph(LayoutPkgNamespaces* layoutns)
, mCurveExplicitlySet ( false )
{
mSubGlyphs.setElementName("listOfSubGlyphs");
//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
//

// setElementNamespace(layoutns->getURI());


connectToChild();

//
// load package extensions bound with this object (if any)
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//
loadPlugins(layoutns);
}


Expand All @@ -150,20 +141,12 @@ GeneralGlyph::GeneralGlyph (LayoutPkgNamespaces* layoutns, const std::string& id
{
mSubGlyphs.setElementName("listOfSubGlyphs");

//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
//

// setElementNamespace(layoutns->getURI());

connectToChild();

//
// load package extensions bound with this object (if any)
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//
loadPlugins(layoutns);
}


Expand All @@ -182,20 +165,12 @@ GeneralGlyph::GeneralGlyph (LayoutPkgNamespaces* layoutns, const std::string& id
{
mSubGlyphs.setElementName("listOfSubGlyphs");

//
// (NOTE) Developers don't have to invoke setElementNamespace function as follows (commentted line)
// in this constuctor because the function is properly invoked in the constructor of the
// base class (LineSegment).
//

// setElementNamespace(layoutns->getURI());

connectToChild();

//
// load package extensions bound with this object (if any)
// (NOTE) Developers don't have to invoke setElementNamespace or loadPlugins functions
// in this constuctor because the functions are properly invoked in the constructor of the
// base class (GraphicalObject).
//
loadPlugins(layoutns);
}

/*
Expand Down
Loading
Loading