Centralize RDF and XHTML keywords into RDFConstants (#288)#289
Open
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Open
Centralize RDF and XHTML keywords into RDFConstants (#288)#289dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RDF and XHTML keywords (like
dc,Bag,rdf,li) were hardcoded as string literals throughout theSBMLRDFAnnotationParser, increasing the risk of typos and making maintenance difficult.Fix
Introduced
org.sbml.jsbml.xml.RDFConstantsto centralize these keywords and updatedSBMLRDFAnnotationParserto use these constants.Testing
mvn -pl core test.Fixes #288