-
Notifications
You must be signed in to change notification settings - Fork 59
Control datetime on SwitchBot Meter Pro CO2 Monitor. #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
951ce6e to
6045f29
Compare
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
92bd5b7 to
d459632
Compare
…chbotMeterProCO2 device.
…MeterProCO2 device.
32b013e to
0b4a4c3
Compare
First, the comment is device-specific. Other devices might implement it differently. Second, top-level comment breaks CI checks.
…replaced byte value comparison with a bit op for consistency with the rest of the codebase.
|
Note: this change provides necessary tools for #416. |
Also replaces a comparison with "80" byte with a bit op for consistency with the rest of the codebase.
|
Rename the file Meter to Meterpro to avoid confusion., The current protocol only applies to MeterPro series devices and does not support Meter type devices. |
But that would make it inconsistent with the advertisement parsers: switchbot/adv_parser/meter.py handles the Pro series too (see |
|
The advertisements for these devices are the same in the first part, but the device setup instructions are quite different. |
To avoid clashing with meter devices, device instructions are different between regular meter vs pro devices.
Ack, thanks for explaining! Restored |
This series of changes adds some control over datetime settings on the SwitchBot Meter Pro CO2 Monitor and aims to support HomeAssistant (see this request to allow syncing the device's time from HA).
This functionality was reverse-engineered, I don't have any access to the Switchbot documentation.
The change can contribute to #430, as it focuses on datetime exclusively and provides more precise control over that.