Add validation rule pd10143 for compartmentRef existence check#77
Open
Drishti160803 wants to merge 1 commit intosbgn:masterfrom
Open
Add validation rule pd10143 for compartmentRef existence check#77Drishti160803 wants to merge 1 commit intosbgn:masterfrom
Drishti160803 wants to merge 1 commit intosbgn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a new Schematron validation rule pd10143 to sbgn_pd.sch.
Problem
Currently there is no validation that checks whether a glyph's
compartmentRef actually points to an existing compartment glyph
in the diagram. A user could set compartmentRef to a non-existent
id and no error would be reported, making diagrams silently invalid.
New rule pd10143
Checks that every glyph with a compartmentRef attribute references
a glyph of class 'compartment' that actually exists in the diagram.
If the rule fails, the error message shows:
Related issue
Closes #76