linter: add file-level override to disable assume_in_transaction#996
Merged
Conversation
Add `-- squawk-disable-assume-in-transaction` and `-- squawk-enable-assume-in-transaction` comments to override the global `assume_in_transaction` setting on a per-file basis. This is useful when a migration tool wraps files in transactions by default but specific files need to opt out (e.g., for `CREATE INDEX CONCURRENTLY`). Closes sbdchd#990 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
reteps
changed the title
assume_in_transaction
sbdchd
reviewed
Mar 20, 2026
Author
|
Marking as draft till this is revamped given @sbdchd's preferences on directions to go in. |
sbdchd
reviewed
Apr 17, 2026
| const ENABLE_ASSUME_IN_TRANSACTION: &str = "squawk-enable-assume-in-transaction"; | ||
|
|
||
| pub fn find_transaction_override(file: &SyntaxNode) -> Option<bool> { | ||
| for event in file.preorder_with_tokens() { |
Owner
There was a problem hiding this comment.
also seems like we'd only want to check the first 20 lines rather than have to look at every comment in the file (including ones that are nested inside other nodes)
Owner
There was a problem hiding this comment.
ignore is a little different since lint errors can occur ~anywhere
reteps
changed the title
assume_in_transactionassume_in_transaction
Only the `squawk-disable-assume-in-transaction` file-level override remains. Renames `find_transaction_override` to `has_disable_assume_in_transaction` since it now only signals one direction. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-- squawk-disable-assume-in-transactionSQL comments to override the globalassume_in_transactionsetting on a per-file basissquawk-ignore/squawk-ignore-filecomment conventions (supports both--and/* */styles, plus trailing comments)CREATE INDEX CONCURRENTLY)Closes #990
Testing
find_transaction_override)squawk-disable-assume-in-transactionallowsCREATE INDEX CONCURRENTLYwhenassume_in_transactionis globally enabledsquawk-disable-assume-in-transactionallows explicitBEGIN/COMMITwhenassume_in_transactionis globally enabled🤖 Generated with Claude Code
Of course, disclaimer, code was written with Claude 4.6 Opus. Feel free to use this PR as a starting point, request changes, or close this out. Thank you!
This is useful to us for the exact reasons I spelled out in #990 -- this will let us turn on more config flags. I changed the comment messages themselves because i felt this better lined up with how the comments worked. I am of course open to other names / ways of configuring on/off.