Skip to content

parser: error for invalid legacy copy stmts #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Jul 2, 2026
Merged

parser: error for invalid legacy copy stmts #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions crates/squawk_parser/src/grammar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12909,6 +12909,19 @@ fn copy_option_list(p: &mut Parser<'_>) {
m.complete(p, COPY_OPTION_LIST);
}

fn opt_copy_force_target(p: &mut Parser<'_>) -> bool {
if p.eat(STAR) {
return true;
}
if name_ref(p).is_none() {
return false;
}
while !p.at(EOF) && p.eat(COMMA) {
name_ref(p);
}
true
}

fn opt_copy_option_item(p: &mut Parser<'_>) -> bool {
let m = p.start();
let parsed = match p.current() {
Expand All @@ -12933,19 +12946,20 @@ fn opt_copy_option_item(p: &mut Parser<'_>) -> bool {
NOT_KW => {
p.bump_any();
p.expect(NULL_KW);
if !p.eat(STAR) {
name_ref_list(p);
}
true
opt_copy_force_target(p)
}
QUOTE_KW | NULL_KW => {
NULL_KW => {
p.bump_any();
if !p.eat(STAR) {
name_ref_list(p);
}
true
opt_copy_force_target(p)
}
QUOTE_KW => {
p.bump_any();
opt_copy_force_target(p)
}
_ => {
p.error("expected NOT, QUOTE, or NULL");
false
}
_ => false,
}
}
_ => false,
Expand Down
5 changes: 5 additions & 0 deletions crates/squawk_parser/tests/data/err/copy.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
-- missing a couple commas
copy x (i y) from '/tmp/input.file' (on_error ignore log_verbosity verbose);

-- legacy force option requires a target
copy t from 's' with force;
copy t from 's' with force null;
copy t from 's' with force zzz;
78 changes: 78 additions & 0 deletions crates/squawk_parser/tests/snapshots/tests__copy_err.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,68 @@ SOURCE_FILE
VERBOSE_KW "verbose"
R_PAREN ")"
SEMICOLON ";"
WHITESPACE "\n\n"
COMMENT "-- legacy force option requires a target"
WHITESPACE "\n"
COPY
COPY_KW "copy"
WHITESPACE " "
PATH
PATH_SEGMENT
NAME_REF
IDENT "t"
WHITESPACE " "
FROM_KW "from"
WHITESPACE " "
LITERAL
STRING "'s'"
WHITESPACE " "
WITH_KW "with"
WHITESPACE " "
FORCE_KW "force"
SEMICOLON ";"
WHITESPACE "\n"
COPY
COPY_KW "copy"
WHITESPACE " "
PATH
PATH_SEGMENT
NAME_REF
IDENT "t"
WHITESPACE " "
FROM_KW "from"
WHITESPACE " "
LITERAL
STRING "'s'"
WHITESPACE " "
WITH_KW "with"
WHITESPACE " "
FORCE_KW "force"
WHITESPACE " "
NULL_KW "null"
SEMICOLON ";"
WHITESPACE "\n"
COPY
COPY_KW "copy"
WHITESPACE " "
PATH
PATH_SEGMENT
NAME_REF
IDENT "t"
WHITESPACE " "
FROM_KW "from"
WHITESPACE " "
LITERAL
STRING "'s'"
WHITESPACE " "
WITH_KW "with"
WHITESPACE " "
FORCE_KW "force"
WHITESPACE " "
ERROR
IDENT "zzz"
EMPTY_STMT
SEMICOLON ";"
WHITESPACE "\n"
---
error[syntax-error]: expected COMMA
Expand All @@ -54,3 +116,19 @@ error[syntax-error]: expected COMMA
╭▸
2 │ copy x (i y) from '/tmp/input.file' (on_error ignore log_verbosity verbose);
╰╴ ━
error[syntax-error]: expected NOT, QUOTE, or NULL
╭▸
5 │ copy t from 's' with force;
╰╴ ━
error[syntax-error]: expected name
╭▸
6 │ copy t from 's' with force null;
╰╴ ━
error[syntax-error]: expected NOT, QUOTE, or NULL
╭▸
7 │ copy t from 's' with force zzz;
╰╴ ━
error[syntax-error]: expected command, found IDENT
╭▸
7 │ copy t from 's' with force zzz;
╰╴ ━
Loading