Skip to content

linter: fix github actions output clobbering json/gcc #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Jun 6, 2026
Merged

linter: fix github actions output clobbering json/gcc #1192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/squawk/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,16 @@ impl Config {
info!("no error on unmatched pattern: {no_error_on_unmatched_pattern:?}");

let is_stdin = !io::stdin().is_terminal();
let github_annotations = std::env::var("GITHUB_ACTIONS").is_ok()
&& std::env::var("SQUAWK_DISABLE_GITHUB_ANNOTATIONS").is_err();

// TODO: we should support all of these in the config file as well
let debug = opts.debug;
let verbose = opts.verbose;
let path_patterns = opts.path_patterns;
let reporter = opts.reporter.unwrap_or_default();
// Don't want to corrupt the other reporters, see issue#1186
let github_annotations = matches!(reporter, Reporter::Tty)
&& std::env::var("GITHUB_ACTIONS").is_ok()
&& std::env::var("SQUAWK_DISABLE_GITHUB_ANNOTATIONS").is_err();
let stdin_filepath = opts.stdin_filepath;
let upload_to_github = conf.upload_to_github;
let upload_to_github_args = match opts.cmd {
Expand Down
Loading