Skip to content

parser: validate default usages #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
May 27, 2026
Merged

parser: validate default usages #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions crates/squawk_parser/tests/data/ok/merge.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ merge into t
b = 1,
c = d,
e = (select 1),
f = row(1, 2, default),
g = (1, 2, default),
h = (default)
when not matched by source then
update set foo = bar;
Expand Down
1 change: 0 additions & 1 deletion crates/squawk_parser/tests/data/ok/select.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,6 @@ select 1 collate;
select foo.bar null;
select foo.bar default;

select default;
select c default;
select null;
select c null;
Expand Down
49 changes: 0 additions & 49 deletions crates/squawk_parser/tests/snapshots/tests__merge_ok.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,55 +1420,6 @@ SOURCE_FILE
R_PAREN ")"
COMMA ","
WHITESPACE "\n "
SET_SINGLE_COLUMN
COLUMN
NAME_REF
IDENT "f"
WHITESPACE " "
EQ "="
WHITESPACE " "
SET_EXPR
CALL_EXPR
NAME_REF
ROW_KW "row"
ARG_LIST
L_PAREN "("
LITERAL
INT_NUMBER "1"
COMMA ","
WHITESPACE " "
LITERAL
INT_NUMBER "2"
COMMA ","
WHITESPACE " "
LITERAL
DEFAULT_KW "default"
R_PAREN ")"
COMMA ","
WHITESPACE "\n "
SET_SINGLE_COLUMN
COLUMN
NAME_REF
IDENT "g"
WHITESPACE " "
EQ "="
WHITESPACE " "
SET_EXPR
TUPLE_EXPR
L_PAREN "("
LITERAL
INT_NUMBER "1"
COMMA ","
WHITESPACE " "
LITERAL
INT_NUMBER "2"
COMMA ","
WHITESPACE " "
LITERAL
DEFAULT_KW "default"
R_PAREN ")"
COMMA ","
WHITESPACE "\n "
SET_SINGLE_COLUMN
COLUMN
NAME_REF
Expand Down
10 changes: 0 additions & 10 deletions crates/squawk_parser/tests/snapshots/tests__select_ok.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5863,16 +5863,6 @@ SOURCE_FILE
DEFAULT_KW "default"
SEMICOLON ";"
WHITESPACE "\n\n"
SELECT
SELECT_CLAUSE
SELECT_KW "select"
WHITESPACE " "
TARGET_LIST
TARGET
LITERAL
DEFAULT_KW "default"
SEMICOLON ";"
WHITESPACE "\n"
SELECT
SELECT_CLAUSE
SELECT_KW "select"
Expand Down
4 changes: 4 additions & 0 deletions crates/squawk_syntax/src/ast/generated/nodes.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/squawk_syntax/src/postgresql.ungram
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,7 @@ Column =
NotEnforced? Enforced?
| 'period'? NameRef
| IndexExpr
| FieldExpr
)
ColumnConstraint =
CheckConstraint
Expand Down
Loading
Loading