Skip to content

cli: fix missing binary exit code#1130

Merged
kodiakhq[bot] merged 2 commits into
sbdchd:masterfrom
nwalters512:fix-missing-binary-exit
May 12, 2026
Merged

cli: fix missing binary exit code#1130
kodiakhq[bot] merged 2 commits into
sbdchd:masterfrom
nwalters512:fix-missing-binary-exit

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

Exit 1 when the npm wrapper fails to spawn the Squawk binary.

This can happen when squawk-cli is installed without running its postinstall script, so js/install.js never downloads js/binaries/squawk. For example, pnpm 10 requires dependency build scripts to be approved, Yarn 4.14+ disables third-party postinstalls by default, and npm supports --ignore-scripts.

Tested:

  • node --check js/bin/squawk
  • missing binary: node js/bin/squawk --version exits 1
  • present binary: node js/bin/squawk --version exits 0

@netlify

netlify Bot commented May 12, 2026

Copy link
Copy Markdown

👷 Deploy request for squawkhq pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c00f084

@nwalters512 nwalters512 marked this pull request as ready for review May 12, 2026 18:31

@sbdchd sbdchd left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sbdchd sbdchd added the automerge automerge with kodiak label May 12, 2026
@sbdchd sbdchd added automerge automerge with kodiak and removed automerge automerge with kodiak labels May 12, 2026
@kodiakhq kodiakhq Bot merged commit 533a39e into sbdchd:master May 12, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge with kodiak

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants