Skip to content

🧪 test: Add tests for idstack-learnings-search#42

Open
savvides wants to merge 1 commit into
mainfrom
test/idstack-learnings-search-tests-11535105294489400644
Open

🧪 test: Add tests for idstack-learnings-search#42
savvides wants to merge 1 commit into
mainfrom
test/idstack-learnings-search-tests-11535105294489400644

Conversation

@savvides

@savvides savvides commented Jun 6, 2026

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed: added tests to cover keyword search and cross-project functionalities in idstack-learnings-search.
📊 Coverage: What scenarios are now tested: keyword search hit, miss, case-insensitivity, and cross-project searches pulling from global learnings.
Result: The improvement in test coverage: script is comprehensively tested.


PR created automatically by Jules for task 11535105294489400644 started by @savvides

Added missing test cases in test/integration-test.sh for `idstack-learnings-search`:
- Keyword searches (hits and misses)
- Keyword case insensitivity
- Cross-project learnings inclusion via --cross-project

Co-authored-by: savvides <1580637+savvides@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds integration tests to test/integration-test.sh for keyword searching (including case-insensitivity and misses) and cross-project global learnings. The feedback suggests replacing a fragile grep assertion on JSON output with a robust Python-based JSON parser assertion to prevent failures from formatting changes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread test/integration-test.sh
Comment on lines +96 to +97
check "cross-project includes global learnings" \
"HOME=\"$TEST_DIR/fake_home\" $IDSTACK_DIR/bin/idstack-learnings-search --cross-project --keyword global_canvas | grep -q '\"_source\": \"global\"'"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using grep to assert JSON structure (like checking for "_source": "global") is fragile because it is sensitive to whitespace, key ordering, and formatting changes (e.g., if the JSON serializer configuration changes to omit spaces around colons).

Since Python is already used in other test assertions in this file, it is more robust to parse the output as JSON and assert the field value directly.

Suggested change
check "cross-project includes global learnings" \
"HOME=\"$TEST_DIR/fake_home\" $IDSTACK_DIR/bin/idstack-learnings-search --cross-project --keyword global_canvas | grep -q '\"_source\": \"global\"'"
check "cross-project includes global learnings" \
"HOME=\"$TEST_DIR/fake_home\" $IDSTACK_DIR/bin/idstack-learnings-search --cross-project --keyword global_canvas | python3 -c \"import json,sys; d=json.loads(sys.stdin.readline()); assert d.get('_source')=='global'\""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant