Skip to content

🧹 Remove dead vestigial symlink cleanup code in setup#32

Open
savvides wants to merge 1 commit into
mainfrom
remove-vestigial-symlink-cleanup-10742332350787755589
Open

🧹 Remove dead vestigial symlink cleanup code in setup#32
savvides wants to merge 1 commit into
mainfrom
remove-vestigial-symlink-cleanup-10742332350787755589

Conversation

@savvides

Copy link
Copy Markdown
Owner

🎯 What: Removed the vestigial bare-symlink cleanup loop and associated comments from the setup script.
💡 Why: The comment in the code explicitly stated that this was dead code left over from pre-marketplace install methods. Removing dead code simplifies the script, improving maintainability and reducing noise.
Verification: Ran bash -n setup to ensure syntax is valid, and ran ./test/smoke-test.sh, ./test/integration-test.sh, ./test/test-manifest-merge.sh, and ./test/test-version-classifier.sh to confirm that all test cases pass properly. The code review also correctly assessed that no functionalities are affected by this safe removal.
Result: The setup script is now cleaner and easier to read without altering any behavior.


PR created automatically by Jules for task 10742332350787755589 started by @savvides

The `setup` script had a vestigial block left over from older setup versions that would symlink the repo into `~/.claude/plugins/idstack`. As the comment stated, this was dead weight since Claude Code now discovers plugins through the marketplace registry. This commit removes that dead code block to improve readability and code health.

Co-authored-by: savvides <1580637+savvides@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the vestigial bare-symlink cleanup logic from the setup script, as current Claude Code versions discover plugins via the marketplace registry rather than symlinks. I have no feedback to provide as there were no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant