🧹 Remove dead vestigial symlink cleanup code in setup#32
Conversation
The `setup` script had a vestigial block left over from older setup versions that would symlink the repo into `~/.claude/plugins/idstack`. As the comment stated, this was dead weight since Claude Code now discovers plugins through the marketplace registry. This commit removes that dead code block to improve readability and code health. Co-authored-by: savvides <1580637+savvides@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request removes the vestigial bare-symlink cleanup logic from the setup script, as current Claude Code versions discover plugins via the marketplace registry rather than symlinks. I have no feedback to provide as there were no review comments.
🎯 What: Removed the vestigial bare-symlink cleanup loop and associated comments from the
setupscript.💡 Why: The comment in the code explicitly stated that this was dead code left over from pre-marketplace install methods. Removing dead code simplifies the script, improving maintainability and reducing noise.
✅ Verification: Ran
bash -n setupto ensure syntax is valid, and ran./test/smoke-test.sh,./test/integration-test.sh,./test/test-manifest-merge.sh, and./test/test-version-classifier.shto confirm that all test cases pass properly. The code review also correctly assessed that no functionalities are affected by this safe removal.✨ Result: The
setupscript is now cleaner and easier to read without altering any behavior.PR created automatically by Jules for task 10742332350787755589 started by @savvides