Open
Conversation
jdbranham
reviewed
Jul 11, 2023
Contributor
There was a problem hiding this comment.
This is a good start, but this should be part of the app instead of an example.
Put it here as a new module ./crawler/ so it can be launched something like python -m crawler.main
Also, to make this usable -
- We should be able to call this and pass the website URL as a parameter
- The saved output should have a reference to the URL it was scraped from
- The saved output should be text and not the raw html
- The crawler should follow links to pages on the same domain, and also scrape them.
Check out this tutorial -
https://www.scrapingbee.com/blog/crawling-python/
Contributor
There was a problem hiding this comment.
Let's create the crawler/scraper as a separate pull request and not together with the postgres example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.