prompts: add more details for the PCI subsystem#293
Conversation
a15c25d to
4740668
Compare
|
Thanks, Krzysztof! Overall I like the change and it might make reviews better. Few concerns though:
|
|
@rgushchin thank you for the feedback! Some things that I didn't think about from the LLM angle. Let me incorporate some feedback from Bjorn, and then from you, and I will push revised document. |
108eded to
bf04f90
Compare
|
@rgushchin let me know if this is any better. |
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
bf04f90 to
6a7b209
Compare
| The following PCI endpoint functions return `ERR_PTR()` on failure, not NULL: | ||
| - **REPORT as bugs**: code-correctness invariants; report as a bug. | ||
| - **Low-severity suggestion**: prose, spelling, formatting, style. | ||
| - **Silent**: unsure, or evidence insufficient to confirm. |
There was a problem hiding this comment.
It might actually hide some real issues. Not a hard blocker, just a note. It seems like there is some % of issues which AI can't reliably decide if it's real or not, so it just really depends if we prefer to miss some bugs or have less noise.
| `review-core.md`, which owns output format and Fixes-tag policy. | ||
| The prose, spelling, and style sections below apply only when | ||
| subjective review is enabled; render their findings per | ||
| `inline-template.md`. Every REPORT-as-bugs finding contributes at |
There was a problem hiding this comment.
This all mechanics doesn't belong to per-subsystem prompts, let's keep it separately.
| ID", "Message"), which doubles as a hint that they are defined in the | ||
| spec. | ||
|
|
||
| ## Referring to Functions, Structs, and Callbacks in Prose |
There was a problem hiding this comment.
I think it's pretty much the same across all subsystems. Do we really need it here? Do you see any specific problems?
|
Thanks, Krzysztof! It's definitely better, but I still have some comments, so probably one more pass before I can merge it. Thanks for working on it! |
The PCI subsystem has some specific needs and wants, so capture some of these for Sashiko. Perhaps with the extra content, Sashiko will be able to capture PCI-specific issues as part of the review process.