Rename the directory with the model definitions#40
Open
gpruss wants to merge 4 commits intosartography:mainfrom
Open
Rename the directory with the model definitions#40gpruss wants to merge 4 commits intosartography:mainfrom
gpruss wants to merge 4 commits intosartography:mainfrom
Conversation
added 4 commits
January 27, 2025 14:56
Rename the 'bpmn' directory into 'models' to i) prevent confusion with the identically named directory in the SpiffWorkflow library and ii) because it also contains DMN definitions. Only track changes in the 'camunda'- and 'tutorial'-subdirectory to allow the user to add their own workflows.
The docker option does not increase the user experience with the CLI example considerably, but adds to the amount of maintenance required (see issue sartography#32).
The timer duration PT1D caused an invalid timer duration exception and there were two start event tasks with the same ID present in the file. Opened the file with the SpiffWorkflow editor and changed the duration to P1D. The duplicated start event was automatically removed by the editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the 'bpmn' directory into 'models' to i) prevent confusion with the identically named directory in the SpiffWorkflow library and ii) because it also contains DMN definitions.
Only track changes in the 'camunda'- and 'tutorial'-subdirectory to allow the user to add their own workflows.