Skip to content

Switch PyPI publishing to Trusted Publishing (OIDC) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manouchehri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch PyPI publishing to Trusted Publishing (OIDC) #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/bindings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,6 @@ jobs:

- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
Comment on lines 233 to 234
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publish-pypi sets an explicit permissions: block with only id-token: write. In GitHub Actions, specifying permissions typically sets all other scopes to none, which can break the earlier actions/download-artifact step (it generally requires actions: read, and often contents: read). Consider expanding the job permissions to include the minimum needed scopes in addition to id-token: write so the publish job can still download the built wheels reliably.

Copilot uses AI. Check for mistakes.

This comment was marked as duplicate.

Sign in to view

Copy link
Copy Markdown
Author

@Manouchehri Manouchehri Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude Would my PR cause this to be an issue though? i.e. did I cause anything to break here?

with:
password: ${{ secrets.PYPI_API_TOKEN }}

publish-npm-platforms:
name: Publish npm platform packages
Expand Down
Loading