Allow ml2 drivers to start their own rpc listeners#92
Draft
sebageek wants to merge 2 commits intostable/2024.1-m3from
Draft
Allow ml2 drivers to start their own rpc listeners#92sebageek wants to merge 2 commits intostable/2024.1-m3from
sebageek wants to merge 2 commits intostable/2024.1-m3from
Conversation
To allow MechanismDrivers to start their own RPC listeners (e.g. for communication with custom agents) the MechanismManager will now call start_rpc_listeners() of each driver. This is done as part of Ml2Plugin.start_rpc_listeners(). It is added as an alternative to create the backends in initialize(), as in cases where a driver is split up into the API and RPC part we want to make sure these backends are only started in the RPC part of neutron. This patch depends on MechanismDrivers.start_rpc_listeners() in neutron-lib[0]. [0] https://review.opendev.org/c/openstack/neutron-lib/+/919589 Change-Id: I31e253180f474abf6d266d23c50f9dc89f17f687 Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/919589 Closes-Bug: #2065198
This reverts commit 8dcac73. With change I31e253180f474abf6d266d23c50f9dc89f17f687 all our drivers should run their RPC stuff within the normal processes and don't need to be part of the workers anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch already upstream since 2024.2, backporting it. Our drivers should be compatible with this, but we should check that they don't start some extra interfaces we don't need. If this works, our own rpc calls will not only be handled by a single process per neutron-rpc-server, but by all of them.