rebasing multicontrast #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated labels to remove additional capitalisations beyond the first word
Changes mini-meta weighting to use the variance of the bootstrapped resampled mean difference distribution, rather than the sample variance. See Cochrane handbook (https://www.cochrane.org/authors/handbooks-and-manuals/handbook/current/chapter-10)
There is an issue with the permutation t-test pvalue test that I'm not sure how to fix at the moment, commented out for now.
Updated baseline image for mini-meta forest plot test to presumably account for the slightly different weighted deltas. This is so pytest can stop failing on Github
Fixes mini-meta weight calculation
sangyu
merged commit 4e1c212
into
sangyu:feat-multicontrast_vortexmap_forest_plot_integration
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.