Y25-703 - Add ability to modify asynchronous accessions#5444
Merged
StephenHulme merged 22 commits intodevelopfrom Jan 15, 2026
Merged
Y25-703 - Add ability to modify asynchronous accessions#5444StephenHulme merged 22 commits intodevelopfrom
StephenHulme merged 22 commits intodevelopfrom
Conversation
Likely only in testing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5444 +/- ##
===========================================
+ Coverage 87.16% 87.19% +0.02%
===========================================
Files 1458 1459 +1
Lines 32658 32681 +23
Branches 3406 3416 +10
===========================================
+ Hits 28467 28495 +28
+ Misses 4177 4171 -6
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yoldas
reviewed
Jan 12, 2026
| def update_accession_number(accession_number, event_user) | ||
| sample.sample_metadata.sample_ebi_accession_number = accession_number | ||
| sample.save | ||
| sample.sample_metadata.save # prevent an infinite loop due to after_save callbacks on sample.save |
Member
There was a problem hiding this comment.
There is a similar call in app/models/accessionable/sample.rb . However, it does save! there. Here it ignores the return value of just save .
yoldas
approved these changes
Jan 12, 2026
yoldas
approved these changes
Jan 15, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5414
This will allow manifest uploads to update accessioned sample data.
Changes proposed in this pull request
Post deployment
Enable feature flag
y25_286_accession_individual_samples_with_sample_accessioning_jobInstructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version