Y25-181 - Upgrade to Rails 7.2#5285
Merged
StephenHulme merged 90 commits intodevelopfrom Jan 22, 2026
Merged
Conversation
[WARN] DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will be removed in Rails 8.0. Use Ruby's built-in BasicObject instead.
StephenHulme
force-pushed
the
y25-181-upgrade-to-rails-72
branch
2 times, most recently
from
5ffc8e3 to
5c71b47
Compare
TODO: figure out why default needed to be added and make it go away
StephenHulme
force-pushed
the
y25-181-upgrade-to-rails-72
branch
from
5c71b47 to
ca61cd6
Compare
StephenHulme
force-pushed
the
y25-181-upgrade-to-rails-72
branch
from
fd8fef8 to
27a7bce
Compare
StephenHulme
force-pushed
the
y25-181-upgrade-to-rails-72
branch
from
4b73d44 to
7dc6930
Compare
StephenHulme
force-pushed
the
y25-181-upgrade-to-rails-72
branch
from
2f29a5f to
f09ed74
Compare
Y25-181 - Fix views tests
tests: attempt to persist seed data and truncate test data
StephenHulme
requested review from
BenTopping,
KatyTaylor,
andrewsparkes,
harrietc52 and
yoldas
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5285 +/- ##
===========================================
+ Coverage 87.19% 87.39% +0.20%
===========================================
Files 1459 1457 -2
Lines 32708 32701 -7
Branches 3423 3422 -1
===========================================
+ Hits 28520 28580 +60
+ Misses 4173 4106 -67
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenTopping
approved these changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
I assume these are unused?
Contributor
Author
There was a problem hiding this comment.
Thanks for checking this.
Yes, it was a partially broken implementation, see the notes in the file.
Also confirmed with @KatyTaylor
This reverts commit 0536c48.
build: add mysql service to workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4720 after changes made in #5375
Changes proposed in this pull request
Instructions for Reviewers
Please see #5410 and #5453 for a subset of the changes made in this PR.
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version