54: Add agent-readable gate result envelope and parsers#89
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a structured Gate result envelope and parsers, surfaces the envelope in heard-chef and ship-it templates, updates Phase 2/Phase 3 gate flows to parse/store envelopes and gate autofix/decision paths, and records envelope summaries in transcripts and configuration docs. ChangesGate Result Envelope Integration
Sequence Diagram(s)sequenceDiagram
participant Orchestrator
participant Runner
participant Parser
participant Template
participant Transcript
Orchestrator->>Runner: execute gate command
Runner->>Parser: stdout/stderr
Parser->>Template: Gate result envelope (summary, failures, flags)
Template->>Orchestrator: render prompt / next-step options
Template->>Transcript: append gate envelope summary event
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.beislid/heard-chef-templates.md:
- Around line 126-130: Add fenced-code block languages ("text") to the two
language-less code fences shown in the diff: the block that starts with "⚠️ The
gate command `<name>` failed to resolve: <reason>." and the block that starts
with "⚠️ Gate `<name>` failed: <envelope.summary>." Replace each triple-backtick
fence with a language-specified fence (```text) so the blocks satisfy MD040;
ensure both the opening and closing fences are updated and that the inner
content is unchanged.
In @.beislid/ship-it-templates.md:
- Around line 46-51: The fenced-code block containing the gate-failure snippet
starting with "⚠️ Gate `<gate-name>` failed: <envelope.summary>." should be
labeled with a language to satisfy MD040; change the opening fence from ``` to
```text (and keep the existing closing fence) so the block becomes a ```text
fenced code block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4f1d6de3-9200-4743-9ae4-249abff8cab9
📒 Files selected for processing (6)
.beislid/heard-chef-templates.md.beislid/output-templates.md.beislid/ship-it-templates.mddocs/configuration.mdskills/heard-chef/phase-3-push.mdskills/ship-it/phase-2-gates.md
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/configuration.md`:
- Around line 159-160: The prose describing the agent-readable "envelope" is
ambiguous and omits canonical field names; update the envelope documentation to
list the exact contract keys and types (e.g., gate_name:string, status:string,
duration_ms:integer, failures:array, retryable:boolean, env_failure:boolean,
summary:string, suggested_action:string, raw_log_path:string|null,
transcript_summary:string|null) and show a clear example JSON envelope and how
`output.parser` metadata connects to built-in parsers; update the "envelope"
paragraph and any shared output templates or examples (references: the described
"envelope" and `output.parser`) so parsers/orchestrators consume deterministic
keys.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 453de653-eb07-4a89-a7d0-940bc5bc230c
📒 Files selected for processing (5)
.beislid/heard-chef-templates.md.beislid/ship-it-templates.mddocs/configuration.mdskills/heard-chef/phase-3-push.mdskills/ship-it/phase-2-gates.md
✅ Files skipped from review due to trivial changes (3)
- skills/heard-chef/phase-3-push.md
- .beislid/ship-it-templates.md
- .beislid/heard-chef-templates.md
Summary
Verification
python3 scripts/validate_skills.pypython3 scripts/check_skill_size_budgets.pygit diff --check $(git merge-base HEAD main)...HEADpython3 tests/agent-smoke/run.py gate ship-it --hosts claude,codex --timeout 900 --changed-onlyReview
Closes #54
Summary by CodeRabbit
New Features
Documentation