#73: Add Homebrew-compatible packaging draft#79
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a draft Homebrew formula and docs, expands the CLI entrypoint to validate required runtime layout (supports overridable BEISLID_HOME), and adds packaged-layout tests and a test helper to exercise Homebrew-style installs and failure messaging. ChangesHomebrew packaging and packaged runtime support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bin/beislid`:
- Around line 22-28: The current conditional only falls back to BEISLID_HOME
when scripts/install_lib.sh is missing; expand it to detect any incomplete
runtime layout by checking all required entries (e.g., scripts/install_lib.sh,
skills/ directory, install.sh) before refusing the current BEISLID_ROOT. Update
the conditional that references BEISLID_ROOT and BEISLID_HOME so it triggers
when BEISLID_HOME is set and any of the required files/dirs are absent (use -f
for files, -d for directories), then preserve the existing logic that sets
BEISLID_ROOT="$(cd "$BEISLID_HOME" && pwd)" if BEISLID_HOME is a directory or
assigns BEISLID_ROOT="$BEISLID_HOME" otherwise.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0dc5f2cd-9980-4de7-96ba-38043f38d1c5
📒 Files selected for processing (6)
README.mdbin/beisliddocs/configuration.mddocs/how-to-use.mdpackaging/homebrew/beislid.rbscripts/test_install.sh
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Summary
packaging/homebrew/beislid.rb.BEISLID_HOMEwhenbin/beislidis separated from the runtime root.Verification
python3 scripts/validate_skills.pybash scripts/test_install.sh— 55 passedruby -c packaging/homebrew/beislid.rbgit diff --checkReview notes
BEISLID_HOMEerror-path gap; fixed and retested..codexandRELEASE_NOTES.mdwere left unstaged and are not part of this PR.Summary by CodeRabbit
New Features
Documentation
Tests