Open
Conversation
|
too many change in one Pr :/, could you split it in different parts ? |
Author
|
Yes, it is a few changes. I don't even remember making this PR. I suspect that I did it this way because it wasn't straight forward to implement Docker support properly without these associated changes. I'd recommend accepting or rejecting this PR as a whole, as I don't know if it would be straight forward to split it into pieces -- I suspect they are mostly connected to the overall goal of the multi-stage Docker implementation. |
|
@saward could you resolve conflict at least ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for docker support. It includes:
I'm creating a PR for what I have in case it's useful, but I don't intend to continue using this project. I don't understand why when I run it, it tries to set up a dingding notification despite there being no such setting in my config.