[WIP] Allow for optimistic locking to be turned on post-production.#704
Open
tpendragon wants to merge 1 commit intomainfrom
Open
[WIP] Allow for optimistic locking to be turned on post-production.#704tpendragon wants to merge 1 commit intomainfrom
tpendragon wants to merge 1 commit intomainfrom
Conversation
tpendragon
force-pushed
the
optimistic_locking_later
branch
from
dc62244 to
f6f9f18
Compare
Data should be persisted in such a way that it's okay if optimistic locking is turned on later, and shouldn't require a data migration. This will require a migration for postgres, but will give a warning if it hasn't been run. Existing data will need to be migrated - maybe delay this for 2.0?
tpendragon
force-pushed
the
optimistic_locking_later
branch
from
f6f9f18 to
73c75cb
Compare
tpendragon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data should be persisted in such a way that it's okay if optimistic
locking is turned on later, and shouldn't require a data migration.
This will require a migration for postgres, but will give a warning if
it hasn't been run. Existing data will need to be migrated - maybe delay
this for 3.0?
The postgres migration will be something like:
Valkyrie::Persistence::Postgres::ORM::Resource.where(lock_version: nil).update_all(lock_version: 0)Maybe we can just put it in the migration for the change default db migration file and that'll be fine?