Skip to content

Test with rails 8.1 / ruby 4 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjcolvar wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Test with rails 8.1 / ruby 4 #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
372a792
Test with rails 8 / ruby 3.4
cjcolvar May 23, 2025
33e99ed
Add csv gem when testing on ruby 3.3+
cjcolvar May 23, 2025
32ce5d9
Appease rubocop
cjcolvar May 23, 2025
20c426f
Upgrade to rdf 3.3.2+ to resolve issue with rdf 3.3.1 and newer faraday
cjcolvar Feb 2, 2026
c659ab0
Drop testing on EOL versions of ruby and rails
cjcolvar Feb 2, 2026
edb4091
Test on ruby 4 + rails 8.1
cjcolvar Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 20 additions & 178 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,100 +48,21 @@ jobs:
workflows:
ci:
jobs:
# Rails 8.1
- bundle_and_test:
name: ruby4-0_rails8-1
ruby_version: 4.0.1
rails_version: 8.1.2
# Rails 8.0
- bundle_and_test:
name: ruby3-4_rails8-0
ruby_version: 3.4.4
rails_version: 8.0.2
# Rails 7.2
- bundle_and_test:
name: ruby3-3_rails7-2
ruby_version: 3.3.4
rails_version: 7.2.0
# Rails 7.1
- bundle_and_test:
name: ruby3-3_rails7-1
ruby_version: 3.3.0
rails_version: 7.1.3
- bundle_and_test:
name: ruby3-2_rails7-1
ruby_version: 3.2.3
rails_version: 7.1.3
- bundle_and_test:
name: ruby3-1_rails7-1
ruby_version: 3.1.4
rails_version: 7.1.3
- bundle_and_test:
name: ruby3-0_rails7-1
ruby_version: 3.0.6
rails_version: 7.1.3
# Rails 7.0
- bundle_and_test:
name: ruby3-3_rails7-0
ruby_version: 3.3.0
rails_version: 7.0.8
- bundle_and_test:
name: ruby3-2_rails7-0
ruby_version: 3.2.3
rails_version: 7.0.8
- bundle_and_test:
name: ruby3-1_rails7-0
ruby_version: 3.1.4
rails_version: 7.0.8
- bundle_and_test:
name: ruby3-0_rails7-0
ruby_version: 3.0.6
rails_version: 7.0.8
- bundle_and_test:
name: ruby2-7_rails7-0
ruby_version: 2.7.8
rails_version: 7.0.8
# Rails 6.1
- bundle_and_test:
name: ruby3-3_rails6-1
ruby_version: 3.3.0
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby3-2_rails6-1
ruby_version: 3.2.3
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby3-1_rails6-1
ruby_version: 3.1.4
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby3-0_rails6-1
ruby_version: 3.0.6
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby2-7_rails6-1
ruby_version: 2.7.8
rails_version: 6.1.7.6
# Rails 6.0
- bundle_and_test:
name: ruby3-3_rails6-0
ruby_version: 3.3.0
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby3-2_rails6-0
ruby_version: 3.2.3
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby3-1_rails6-0
ruby_version: 3.1.4
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby3-0_rails6-0
ruby_version: 3.0.6
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby2-7_rails6-0
ruby_version: 2.7.8
rails_version: 6.0.6.1
# Rails 5.2
- bundle_and_test:
name: ruby3-0_rails5-2
ruby_version: 3.0.6
rails_version: 5.2.8.1
- bundle_and_test:
name: ruby2-7_rails5-2
ruby_version: 2.7.8
rails_version: 5.2.8.1

nightly:
triggers:
Expand All @@ -153,97 +74,18 @@ workflows:
- main

jobs:
# Rails 8.1
- bundle_and_test:
name: ruby4-0_rails8-1
ruby_version: 4.0.1
rails_version: 8.1.2
# Rails 8.0
- bundle_and_test:
name: ruby3-4_rails8-0
ruby_version: 3.4.4
rails_version: 8.0.2
# Rails 7.2
- bundle_and_test:
name: ruby3-3_rails7-2
ruby_version: 3.3.4
rails_version: 7.2.0
# Rails 7.1
- bundle_and_test:
name: ruby3-3_rails7-1
ruby_version: 3.3.0
rails_version: 7.1.3
- bundle_and_test:
name: ruby3-2_rails7-1
ruby_version: 3.2.3
rails_version: 7.1.3
- bundle_and_test:
name: ruby3-1_rails7-1
ruby_version: 3.1.4
rails_version: 7.1.3
- bundle_and_test:
name: ruby3-0_rails7-1
ruby_version: 3.0.6
rails_version: 7.1.3
# Rails 7.0
- bundle_and_test:
name: ruby3-3_rails7-0
ruby_version: 3.3.0
rails_version: 7.0.8
- bundle_and_test:
name: ruby3-2_rails7-0
ruby_version: 3.2.3
rails_version: 7.0.8
- bundle_and_test:
name: ruby3-1_rails7-0
ruby_version: 3.1.4
rails_version: 7.0.8
- bundle_and_test:
name: ruby3-0_rails7-0
ruby_version: 3.0.6
rails_version: 7.0.8
- bundle_and_test:
name: ruby2-7_rails7-0
ruby_version: 2.7.8
rails_version: 7.0.8
# Rails 6.1
- bundle_and_test:
name: ruby3-3_rails6-1
ruby_version: 3.3.0
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby3-2_rails6-1
ruby_version: 3.2.3
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby3-1_rails6-1
ruby_version: 3.1.4
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby3-0_rails6-1
ruby_version: 3.0.6
rails_version: 6.1.7.6
- bundle_and_test:
name: ruby2-7_rails6-1
ruby_version: 2.7.8
rails_version: 6.1.7.6
# Rails 6.0
- bundle_and_test:
name: ruby3-3_rails6-0
ruby_version: 3.3.0
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby3-2_rails6-0
ruby_version: 3.2.3
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby3-1_rails6-0
ruby_version: 3.1.4
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby3-0_rails6-0
ruby_version: 3.0.6
rails_version: 6.0.6.1
- bundle_and_test:
name: ruby2-7_rails6-0
ruby_version: 2.7.8
rails_version: 6.0.6.1
# Rails 5.2
- bundle_and_test:
name: ruby3-0_rails5-2
ruby_version: 3.0.6
rails_version: 5.2.8.1
- bundle_and_test:
name: ruby2-7_rails5-2
ruby_version: 2.7.8
rails_version: 5.2.8.1
2 changes: 2 additions & 0 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,11 @@ Performance/StringReplacement:
# Configuration parameters: EnforceForPrefixed.
Rails/Delegate:
Exclude:
- 'lib/ldp/client.rb'
- 'lib/ldp/client/prefer_headers.rb'
- 'lib/ldp/orm.rb'
- 'lib/ldp/response.rb'
- 'lib/ldp/uri.rb'

# Offense count: 4
# Cop supports --auto-correct.
Expand Down
3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,8 @@ if ENV['RAILS_VERSION']
end
end

# rdf-tabular has a dependency on csv but it was removed from the ruby standard library starting in 3.4
gem "csv", "~> 3.0" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3')

# Specify your gem's dependencies in ldp-client.gemspec
gemspec
2 changes: 1 addition & 1 deletion ldp.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "faraday", '>= 1'
spec.add_dependency "http_logger"
spec.add_dependency "json-ld", "~> 3.2"
spec.add_dependency "rdf", "~> 3.2"
spec.add_dependency "rdf", "~> 3.2", ">= 3.3.2"
spec.add_dependency "rdf-isomorphic"
spec.add_dependency "rdf-ldp", ">= 2.1"
spec.add_dependency "rdf-turtle"
Expand Down
2 changes: 1 addition & 1 deletion lib/ldp/container.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def add *args
# slug

case
when (args.length > 2 || args.length == 0)
when args.length > 2 || args.length == 0

when (args.length == 2)
slug, graph_or_content = args
Expand Down
2 changes: 1 addition & 1 deletion lib/ldp/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def save
def create &block
raise Ldp::Conflict, "Can't call create on an existing resource (#{subject})" unless new?
verb = subject.nil? ? :post : :put
resp = client.send(verb, (subject || @base_path), content) do |req|
resp = client.send(verb, subject || @base_path, content) do |req|
req.headers["Link"] = "<#{interaction_model}>;rel=\"type\"" if interaction_model
yield req if block_given?
end
Expand Down