Adding support for top-level options configuration#27
Open
fnavarijo wants to merge 5 commits intosamtgarson:masterfrom
Open
Adding support for top-level options configuration#27fnavarijo wants to merge 5 commits intosamtgarson:masterfrom
fnavarijo wants to merge 5 commits intosamtgarson:masterfrom
Conversation
samtgarson
approved these changes
Apr 16, 2020
Owner
samtgarson
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution. I will release this in a new version shortly.
|
Thanks for this PR, I'm hoping this will get merged and released soon because this can be really usefull. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: Adding top-level configuration module support
This update let users to configure keys via top-level options.
I think this enhancement let users organize in a better way the env keys that will be injecting to the project. I only added this enhancement, the behavior to inject via env prop and module options keeps the same Here is an example
Any suggestion or correction you think must be made, let met know to do it.
Thanks for this awesome project.
PD. I also updated circle pipeline definition to use npm.