This repository was archived by the owner on Jun 27, 2020. It is now read-only.
Adding user agent name and version to client constructor.#32
Open
na-g wants to merge 1 commit intosamsymons:masterfrom
Open
Adding user agent name and version to client constructor.#32na-g wants to merge 1 commit intosamsymons:masterfrom
na-g wants to merge 1 commit intosamsymons:masterfrom
Conversation
User Agent string is now easy to generate correctly Client ctor has new optional parameters for constructing the user agent string. The user agent string can still be set manually. Added tests relavent tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Agent string is now easy to generate correctly
Client ctor has new optional parameters for constructing the user agent string.
The user agent string can still be set manually.
Added tests relavent tests.
Updated README.md