Fix bugs in Range class #4
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what I believe to be 3 small bugs in the Range class. I have not tested this yet but the compiler complained about these so I went and analyzed the problems. I actually am still in the process of getting familiar with your code-base so this may all be wrong, but I am fairly convinced these changes make sense.
To start with, the class Range does not provide begin() and end() methods, so the change on line 328 should be correct.
Also, the for loops both start by calling the begin() method on a Ranges object, so I believe the type of iterator should be Ranges::iterator rather than a Vectors::iterator.
By the way, I am trying to create a Python interface to your library, using SWIG. I am not sure how horrible my code is on a scale 1:10, so I will put it on GitHub when horribleness is < 4.