Skip to content

Conversation

@marcotama
Copy link

This fixes what I believe to be 3 small bugs in the Range class. I have not tested this yet but the compiler complained about these so I went and analyzed the problems. I actually am still in the process of getting familiar with your code-base so this may all be wrong, but I am fairly convinced these changes make sense.

To start with, the class Range does not provide begin() and end() methods, so the change on line 328 should be correct.
Also, the for loops both start by calling the begin() method on a Ranges object, so I believe the type of iterator should be Ranges::iterator rather than a Vectors::iterator.

By the way, I am trying to create a Python interface to your library, using SWIG. I am not sure how horrible my code is on a scale 1:10, so I will put it on GitHub when horribleness is < 4.

@marcotama
Copy link
Author

Actually, the title is mistyped, it's the Ranges class.

@victor2105
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants