Add support for NUnit3TestGeneratorProvider.#1
Open
DavidKorn wants to merge 1 commit intosamholder:masterfrom
Open
Add support for NUnit3TestGeneratorProvider.#1DavidKorn wants to merge 1 commit intosamholder:masterfrom
DavidKorn wants to merge 1 commit intosamholder:masterfrom
Conversation
Previously SpecFlow.NCrunch forced the use of the legacy NUnitTestGeneratorProvider, which does not set a Reason string when creating NUnit Ignore attrbiutes. This Ignore Reason is a required value for NUnit3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously SpecFlow.NCrunch invoked use of the older NUnitTestGeneratorProvider under the newer NUnit 3. This older provider does not set a Reason parameter when creating NUnit Ignore attrbiutes, however a non-empty Ignore Reason is now required under NUnit 3. So the effect was that use of SpecFlow.NCrunch was changing SpecFlow behavior such that generated tests would not build for NUnit 3. SpecFlow normally uses the newer NUnit3TestGeneratorProvider which addresses the Ignore Reason issue. This small patch aligns SpecFlow.NCrunch to do the same.