A couple improvements#1
Open
jmhooper wants to merge 4 commits intosamfadrigalan:masterfrom
jmhooper:master
Open
A couple improvements#1jmhooper wants to merge 4 commits intosamfadrigalan:masterfrom jmhooper:master
jmhooper wants to merge 4 commits intosamfadrigalan:masterfrom
jmhooper:master
Conversation
added 4 commits
September 10, 2015 20:22
This commit adds a standard gitignore for a node project and sets up removes files that shouldn't be tracked.
I added some missing packages to the package.json. I also updated the startup script so that it relies on the local nodemon module instead of the global one.
I removed a hardcoded file path from login.js to prevent a "read file error" I also logged the stack for the "read file error" to make the logs more helpful.
Moving your username and your password in your query params is really bad. I moved the params into the request body of a POST request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled across this project and I added a few things to this project to make it look a little bit better. You can merge them if you want.
npm install && npm start