Develop - Wireless ADB QR pair, Reconnecting message, menubar text marquee and a lot more fixes#246
Conversation
…cessing in OutboundNearbyConnection
Re applied all the notification fixes indivividually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a marquee (scrolling) text feature for the menubar status, allowing long text (such as device names or music info) to scroll smoothly instead of being truncated. It also improves notification handling and discovery network triggers, and makes several code quality and UX updates.
Menubar Marquee Feature:
MarqueeTextSwiftUI component that displays scrolling text when content exceeds the available width, using efficient Core Animation for performance (MarqueeText.swift).enableMarqueeis set, device names, music info, and drag labels in the menubar will scroll instead of being truncated (MenuBarManager.swift). [1] [2] [3]enableMarqueeas a user preference inAppState, persisted viaUserDefaultsand exposed as a published property (AppState.swift). [1] [2]AppState.swift).Notification Improvements:
AppState.swift).AppState.swift).isConnectionWeakstate is reset to avoid stale UI (AppState.swift).AppState.swift). [1] [2]Discovery/Networking Resilience:
UDPDiscoveryManager.swift). [1] [2] [3]Code Quality and UI Consistency:
MenuBarManager.swift). [1] [2]MenuBarManager.swift).Assets:
adb-pair.jpegandadb-pair-prompt.jpeg). [1] [2]