WIP feature: sdds-uikit-compose migration on KMP #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
malilex
commented
Feb 18, 2025
malilex
commented
malilex
changed the title
vkaltyrin
reviewed
Feb 18, 2025
|
|
||
| android { | ||
| val vInfo = versionInfo() | ||
| // sourceSets["main"].manifest.srcFile("src/androidMain/AndroidManifest.xml") |
Collaborator
There was a problem hiding this comment.
@malilex почему закоммичен закомментированный код?
Collaborator
Author
There was a problem hiding this comment.
это ж wip, я запушил, чтобы другие могли оценить объем доработок при миграции.
вливать этот ПР мы еще не скоро будем, да и работа еще не закончена
vkaltyrin
reviewed
Feb 18, 2025
| // "sdds-uikit-compose" -> useTarget( | ||
| // "sdds-core:uikit-compose:*", | ||
| // "we work with the unreleased development version" | ||
| // ) |
Collaborator
There was a problem hiding this comment.
@malilex и здесь тоже закомментированный код, надо удалить?
malilex
force-pushed
the
develop
branch
11 times, most recently
from
8d0433c to
e5eb069
Compare
raininforest
force-pushed
the
develop
branch
from
6331724 to
4aef140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.