Add missing rich.markup.escape import in tools/ci.py#69397
Closed
dwoz wants to merge 1 commit into
Closed
Conversation
The dependabot-group PR saltstack#69391 carries a 'Fix rich MarkupError when rendering dependabot PR body' commit that calls escape() in workflow_config without importing it, so Prepare Workflow Run fails with NameError: name 'escape' is not defined and blocks every downstream job. Landing the proper fix on master so a @dependabot rebase on saltstack#69391 picks up a working tools/ci.py. Mirrors the matching fix in saltstack#69395 on 3006.x.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependabot-group PR #69391 carries a 'Fix rich MarkupError when rendering dependabot PR body' commit that calls
escape()inworkflow_configwithout importing it, so Prepare Workflow Run fails withNameError: name 'escape' is not definedand blocks every downstream job.Landing the proper fix (with
from rich.markup import escape) on master so a@dependabot rebaseon #69391 picks up a workingtools/ci.py.Mirrors the matching fix in #69395 on 3006.x.