fix: guard against non-iterable target in list_jobs search_target#68862
Open
joaquinhuigomez wants to merge 1 commit intosaltstack:masterfrom
Open
fix: guard against non-iterable target in list_jobs search_target#68862joaquinhuigomez wants to merge 1 commit intosaltstack:masterfrom
joaquinhuigomez wants to merge 1 commit intosaltstack:masterfrom
Conversation
When search_target is used in list_jobs, the code assumed Target would always be a string or list. Execution/state failures can leave Target as a non-iterable value (e.g. int), causing a TypeError. Skip non-iterable targets instead of crashing. Closes saltstack#68780
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
search_targetis used inlist_jobs, the code assumesTargetis always a string or list. Execution and state failures can leaveTargetas a non-iterable value (e.g. an integer), which causes aTypeErrorwhen iterating.This adds a type check that converts non-iterable, non-string targets to an empty list so they are safely skipped instead of crashing.
Includes a unit test covering the non-iterable target case.
Closes #68780